#102 Error when saving album settings from the settings tab

Closed
opened 1 year ago by aheathershaw · 2 comments

When you edit an album’s settings within the Settings tab of the album itself, you get an error.

Changing the album through the album’s edit screen works fine.

When you edit an album’s settings within the Settings tab of the album itself, you get an error. Changing the album through the album’s edit screen works fine.
aheathershaw self-assigned this 1 year ago
aheathershaw added the
bug
label 1 year ago
aheathershaw commented 1 year ago
Owner

This is due to the validation added in #58, allowing albums with the same name to exist under different parents.

The settings tab does not have the “parent” field that the Edit screen does, so it causes an undefined index trying to access the field’s value.

The validation needs to use the album’s current parent when this field is not present in the data.

This is due to the validation added in #58, allowing albums with the same name to exist under different parents. The settings tab does not have the “parent” field that the Edit screen does, so it causes an undefined index trying to access the field’s value. The validation needs to use the album’s current parent when this field is not present in the data.
aheathershaw added this to the (deleted) milestone 1 year ago
aheathershaw commented 3 months ago
Owner

This is also present in Cloud, needs fixing in 2.2.0 and merging across.

This is also present in Cloud, needs fixing in 2.2.0 and merging across.
aheathershaw modified the milestone from (deleted) to Version 2.2.0-beta.1 3 months ago
aheathershaw added the
wip
label 3 months ago
aheathershaw removed the
wip
label 3 months ago
Sign in to join this conversation.
No Milestone
No Assignees
1 Participants
Due Date

No due date set.

Dependencies

This issue currently doesn't have any dependencies.

Loading…
Cancel
Save
There is no content yet.